Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Fixes wrong function call in ProjectManager.js #13611

Merged
merged 1 commit into from
Aug 13, 2017
Merged

Conversation

hkirat
Copy link
Contributor

@hkirat hkirat commented Aug 12, 2017

The createNewItem function in ProjectManager.js calls the createAtPath in Projectmodel.js.

The function call expects a single parameter, which is the path at which the file must be created.
And it expects a "/" in the end of the path in case it is a folder.

However, right now 2 parameters are being passed. One of them being the isFolder variable.

The createNewItem function in ProjectManager.js calls the createAtPath in Projectmodel.js.

The function call expects a single parameter, which is the path at which the file must be created.
And it expects a "/" in the end of the path in case it is a folder.

However, right now 2 parameters are being passed. One of them being the isFolder variable.
@saurabh95 saurabh95 self-requested a review August 12, 2017 16:43
@saurabh95
Copy link
Contributor

Thanks for the contribution!
Could you please sign the agreement http://dev.brackets.io/brackets-contributor-license-agreement.html ?
This might be one of the reason because of cla check failing.

@hkirat
Copy link
Contributor Author

hkirat commented Aug 12, 2017

Signed it!

Copy link
Collaborator

@swmitra swmitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @hkirat 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants